-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile save function sets the PROJ variable in the Makefile to the actual name the project was saved with. #260
Conversation
…project config and custom_modules with a folder structure.
… and custom_modules deep folder structure.
…ith the config and custome_modules deep folder structure.
…tch_deep_custom_modules
…ble with the config and custome_modules deep folder structure.
…gs.xml-default instead of config/PhysiCell_settings-backup.xml to restore initial condition.
…the actual name the project was saved with.
The sed command does indeed seem to work on my Windows machine. But I'm still a bit confused. When I did |
Looks like a very thorough set of changes and a nifty way to make it easier to use |
@rheiland, that is a good point. I can do the change to the Makefiles before I copy to the users_project folder. @drbergman , there was no "conclusion" you just expressed your opinion. |
On my Mac, the native
I remember now that for a past project, I had to brew install the gnu sed to do what I wanted. So this |
yes @rheiland, this is the exact same error we had last time. I think we should not have the user to install a specific sed. |
reading up on the subject, this might work on the native Mac, but does not work on linux, and maybe as well not on a Mac with gnu-sed installed ...
I will search further. |
well, we would have to figure out if the GNU sed or the BSD sed is installed. |
this awk line should do the same:
I will update the code with the changes discussed, let you know when it is done, and would be happy if you then can check again. |
…instead of sed, to be hopefully compatible with all supported platforms and unix flavors.
@rheiland i just pushed the changes. |
On my Mac, native
|
why the heck Berkeley Software Distribution? |
at least on Windows it seems to work. |
I don't understand the purpose of this PR and change. I think it's a bad idea to overwrite the Makefile.
Right now, the design and default behavior is to default to In that sense, the original PR is incorrect, because you are in fact not fixing a bug. It is functioning exactly as intended. Is your intention that once a user sets Please give a design goal/justification for the complex change you are trying to work through. Please also consider simpler workarounds (with more cross-platform robustness) than writing to the Makefile (e.g., writing to a text file |
ok. I think you understood what my intention was. i always understood a
(look in now over the whole Makefile, i wonder why we actually have two variables anyhow, I will drop this pull request but keep the #244 pull request alive, which solves the deep folder structure. thank you, Elmar |
This pull request is written on top of pull request #244 and addresses issue #222 .
What the pull request solves:
The Makefile save function now sets the PROJ variable in the Makefile to the actual name the project was saved with.
Before when e.g. a project was saved with
the save project had his PROJ variable still set to
or whatever the PROJ variable was set before.
Now the saved project will have set the PROJ variable correctely to
as it should be.
This is a crucial change because it will prevent users from down the road overwriting accidentally the original project from which the newly saved project was derived from.
@rheiland, because this changes use a sed command, cloud you, please check if this works on the Windows bash shell and on MacOSX zsh shell? That would be very helpful!